fix: Switch from temp-dir to a homemade NamedTempFile implementation - #23206
Merged
Conversation
That also deletes the file when the process exits without being dropped; this is important especially for the proc macro server since it is killed and does not exit normally. Linux and the BSDs unlink the file then access it via `/proc/self/fd` or `/dev/fd`; Windows has a dedicated API for that; and macOS unfortunately does not support that (the file is not removed after being unlinked, but you cannot access it anymore via `/dev/fd`, or at least that's what the AI said - I don't have a macOS machine to check).
rustbot
added
the
S-waiting-on-review
ShoyuVanilla
approved these changes
Aug 26, 2026
rustbot
removed
the
S-waiting-on-review
This was referenced Aug 26, 2026
Open
Contributor
Author
Credit where credit is due; this was the AI's idea (not original probably). Of course I verified in the POSIX specification that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That also deletes the file when the process exits without being dropped; this is important especially for the proc macro server since it is killed and does not exit normally.
Linux and the BSDs unlink the file then access it via
/proc/self/fdor/dev/fd; Windows has a dedicated API for that; and macOS unfortunately does not support that (the file is not removed after being unlinked, but you cannot access it anymore via/dev/fd, or at least that's what the AI said - I don't have a macOS machine to check).Fixes #23203.