Skip to content

chore: Switch to Biome for TypeScript formatting and linting + update to TypeScript 7 - #23158

Open
BenjaminBrienen wants to merge 3 commits into
rust-lang:masterfrom
BenjaminBrienen:biome
Open

chore: Switch to Biome for TypeScript formatting and linting + update to TypeScript 7#23158
BenjaminBrienen wants to merge 3 commits into
rust-lang:masterfrom
BenjaminBrienen:biome

Conversation

@BenjaminBrienen

@BenjaminBrienen BenjaminBrienen commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

https://rust-lang.zulipchat.com/#narrow/channel/185405-t-compiler.2Frust-analyzer/topic/TypeScript.207/with/616786210

I can start removing those "off" lint configurations in this PR or in a follow-up

@BenjaminBrienen
BenjaminBrienen marked this pull request as ready for review August 16, 2026 13:16
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 16, 2026
@BenjaminBrienen BenjaminBrienen changed the title Switch to Biome for TypeScript formatting and linting chore: Switch to Biome for TypeScript formatting and linting + update to TypeScript 7 Aug 16, 2026
Comment thread editors/code/biome.jsonc Outdated

@ChayimFriedman2 ChayimFriedman2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely not a fan of having to change all our TypeScript files to accommodate for new lints. If Biome cannot support the existing lints we have, I don't want it.

View changes since this review

@BenjaminBrienen

BenjaminBrienen commented Aug 16, 2026

Copy link
Copy Markdown
Contributor Author

It's just import sorting and changing the eslint comments to biome comments. I can turn off import sorting if you want. Would you accept it then? I already made sure that there are no "new" lints and it does support the existing lints. The only difference is the syntax for silencing them.

@ChayimFriedman2

Copy link
Copy Markdown
Contributor

If the changes are minimal (a few edits, definitely not +677 -1,374), I still have the question whether we want it as I said on Zulip, but this is not blocking from my side.

@BenjaminBrienen

BenjaminBrienen commented Aug 16, 2026

Copy link
Copy Markdown
Contributor Author

+516 -1,174 is the lockfile being updated (no more eslint-related packages and updating typescript). The changes to *.ts files is small.

$ git diff master HEAD --shortstat -- '*.ts'
19 files changed, 90 insertions(+), 96 deletions(-)

I understand, no worries if it is not wanted.

@ChayimFriedman2

Copy link
Copy Markdown
Contributor

😲 I thought GitHub ignored it in the counting...

@lnicola

lnicola commented Aug 16, 2026

Copy link
Copy Markdown
Member

I feel it's worth taking some formatting changes if we can move to tools that are less dependent on the JS ecosystem. We''re on our third bundler, but it does feel lighter.

@BenjaminBrienen

Copy link
Copy Markdown
Contributor Author

tools that are less dependent on the JS ecosystem.

Maybe someday VS Code will support deno.

@Veykril

Veykril commented Aug 17, 2026

Copy link
Copy Markdown
Member

Yea this sounds fine to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants