Repository navigation
ci: Resolve most zizmor findings as of zizmor@1.32.0 - #3261
Open
hashcatHitman wants to merge 11 commits into
Open
hashcatHitman wants to merge 11 commits into
hashcatHitman wants to merge 11 commits into
Conversation
See: https://github.com/actions/checkout/releases/tag/v7.0.1 This is the same version we're already implicitly using. Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
See: https://github.com/actions/setup-node/releases/tag/v7.1.0 This is the same version we were already implicitly using. Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
See: https://github.com/crate-ci/typos/releases/tag/v1.50.3 This is the same version we're already using. Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
It exists, but not where `zizmor` expects. Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
hashcatHitman
commented
Nov 4, 2026
Comment on lines
+61
to
+62
| with: | ||
| persist-credentials: true # The `publish-guide.sh` script requires this for `git push` |
Member
Author
There was a problem hiding this comment.
I want to get rid of this eventually. I'm pretty sure we wouldn't need it if we migrated to using actions/deploy-pages, which I do think should be done, but I don't currently have the time to figure that out.
Comment on lines
+19
to
+20
| with: | ||
| persist-credentials: true # The `update-dependencies.sh` script requires this for `git push` |
Member
Author
There was a problem hiding this comment.
I don't like this either, but as long as this repo needs that script, it is necessary. We (t-crabwatch/t-infra) should probably try to figure out what behavior is desired and if we can help configure Renovate to provide that behavior.
Member
Author
|
CI failure is from |
Member
Author
|
r? crabwatch |
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
hashcatHitman
marked this pull request as ready for review
November 4, 2026 18:03
hashcatHitman
moved this from zizmor PR opened
to zizmor PR in review
in t-crabwatch policy expansion
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In pursuit of getting more
zizmorlints enforced acrossrust-langrepos throughcrabwatch, this PR fixes mostzizmorfindings as ofzizmor@1.32.0, using theauditorpersona. The lints that actually fired per-persona level are:regularpersona findings:artipacked(seeauditor, though)excessive-permissions(See also: Solve theexcessive-permissionslint crabwatch#97)template-injectionunpinned-usespedanticpersona findings:regularexcessive-permissions(See also: Solve theexcessive-permissionslint crabwatch#97)template-injectionundocumented-permissionsanonymous-definition(Because coming up with names is hard and there is minimal benefit to this)concurrency-limits(Due to concerns about special cases. See also: Determine special cases forconcurrency-limitscrabwatch#107)auditorpersona findings:pedanticartipacked(auditoralso flags explicitly persisted credentials, which were required to keep these workflows functional. they might be removable in the future, but for now, this is just how it is.)