Skip to content

musl: Add *_SUPER_MAGIC constants - #5453

Merged
tgross35 merged 1 commit into
rust-lang:mainfrom
mati865:push-pxnvoyworvvl
Aug 31, 2026
Merged

musl: Add *_SUPER_MAGIC constants#5453
tgross35 merged 1 commit into
rust-lang:mainfrom
mati865:push-pxnvoyworvvl

Conversation

@mati865

@mati865 mati865 commented Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

IIUC, they were not added as part of #2639 because Musl kernel headers were too old.

Checklist

  • Relevant tests in libc-test/semver have been updated
  • Commit messages permalink to headers for added or changed API
  • Placeholder or unstable values like *LAST or *MAX have the standard
    doc comment
  • Tested locally (cargo test -p libc-test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot rustbot added O-linux O-linux-like O-musl O-unix stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Aug 31, 2026
@mati865
mati865 force-pushed the push-pxnvoyworvvl branch from cb8dbda to b5d48db Compare August 31, 2026 10:43
@tgross35

tgross35 commented Aug 31, 2026

Copy link
Copy Markdown
Member

You can just move them from linux/gnu/mod.rs and linux/uclibc/mod.rs to linux/mod.rs since they should be the same. You might need to update libc-test/build/main.rs

@mati865

mati865 commented Aug 31, 2026

Copy link
Copy Markdown
Member Author

@rustbot label -stable-nominated

Messed up the template a bit with jj-gh. Fixed it, but I for some reason musl tests fail to build on my glibc based box.

@rustbot rustbot removed the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Aug 31, 2026
@mati865

mati865 commented Aug 31, 2026

Copy link
Copy Markdown
Member Author

You can just move them from linux/gnu/mod.rs and linux/uclibc/mod.rs to linux/mod.rs since they should be the same.

Ah, Android is linux_like, not linux. Makes sense then.

@mati865
musl: Add *_SUPER_MAGIC constants
ed3b731 
IIUC, they were not added as part of
rust-lang#2639 because Musl kernel headers
were too old.
@mati865
mati865 force-pushed the push-pxnvoyworvvl branch from b5d48db to ed3b731 Compare August 31, 2026 11:09
@rustbot rustbot added the O-gnu label Aug 31, 2026
@mati865
mati865 marked this pull request as ready for review August 31, 2026 11:43
tgross35
tgross35 approved these changes Aug 31, 2026
View reviewed changes

@tgross35 tgross35 left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

View changes since this review

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Aug 31, 2026
@tgross35
tgross35 added this pull request to the merge queue Aug 31, 2026
Merged via the queue into rust-lang:main with commit 4db6d73 Aug 31, 2026
58 checks passed
@mati865
mati865 deleted the push-pxnvoyworvvl branch August 31, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

No one assigned

Labels

O-gnu O-linux O-linux-like O-musl O-unix stable-nominated This PR should be considered for cherry-pick to libc's stable release branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mati865 @tgross35 @rustbot