Use Padding and make private public padding fields - #5444
Open
dybucc wants to merge 1 commit into
Open
Conversation
4 tasks
Change public padding fields to be both private and use the `Padding` type. This has already been the norm for some time now, but there was still some cruft left. This patch finishes up the work, though this comes at the cost of breaking changes.
dybucc
force-pushed
the
add-padding-remaining-public
branch
from
August 30, 2026 13:47
988168b to
e75fae0
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
tgross35
changed the title
Padding and make private public padding fieldsPadding and make private public padding fields
Collaborator
|
☔ The latest upstream changes (possibly #5434) made this pull request unmergeable. Please resolve the merge conflicts. |
tgross35
approved these changes
Aug 31, 2026
tgross35
added
the
stable-declined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stems from #5435, but contains only the parts of the
patchset that affect currently public record fields.
Checklist
libc-test/semverhave been updated*LASTor*MAXhave thestandard doc comment
cargo test -p libc-test --target mytarget);especially relevant for platforms that may not be checked in CI