correct siginfo_t and add other signal related items for redox

[auronandace]

Corrected siginfo_t to match relibc:

• siginfo struct (siginfo_t struct in libc)
• siginfo_t pub type pointing to siginfo

Added the following items:

• sigaltstack struct (stack_t struct in libc)
• stack_t pub type pointing to sigaltstack struct
• sigaltstack function
• SS_ONSTACK constant
• SS_DISABLE constant
• pid_t type

These changes, when released in a stable 0.2.x release, will allow us to use upstream libc for compiling wasmtime natively on Redox.

Edited to add the following:

• ucontext struct
• ucontext_t pub type pointing to ucontext
• mcontext struct x86_64
• mcontext struct x86
• mcontext struct aarch64
• mcontext struct riscv64
• mcontext_t pub type pointing to mcontext struct

[JohnTitor]

Thanks!

View changes since this review

[JohnTitor]

Let me try if bors could squash here,
@bors squash

[JohnTitor]

Seems not, @auronandace could you squash commits into one?

[auronandace]

I don't understand how to squash. I tried following this: https://www.geeksforgeeks.org/git/git-squash/

I can tell you my main branch of my libc now has just the one commit which seems to have this redox-signal branch commit squashed into one.

[tgross35]

The usual sequence would be:

1. Start a rebase without changing the base, using git rebase -i main --keep-base. (Or omit --keep-base to change the base as well)
2. In the editor, change "pick" to "f" (or "fixup") on all but the first commit. Save+exit
3. Your local is up to date. Update github with git push --force-with-lease

You could have the first two steps completed already but might just need to do the third. If you get stuck, we can also do it for you.

[auronandace]

CI seems to be saying #[repr(C)] attribute is being used multiple times. This wasn't failing in CI before. All the structs that specify it only specify it once so I'm not quite following what is going on. Is the macro adding it automatically too?

[tgross35]

Try the same thing without --keep-base, after making sure your local main is up to date (if you're not sure how, git fetch https://github.com/rust-lang/libc.git main:main should do it) to grab the latest changes. That was fixed recently.

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[rustbot]

⚠️ Warning ⚠️

• The following commits have merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

  • 4bfd31b

  You can start a rebase with the following commands:

  $ # rebase
  $ git pull --rebase https://github.com/rust-lang/libc.git main
  $ git push --force-with-lease
  

[auronandace]

CI seems to be showing the same error.

[auronandace]

I'm not sure what the protocol is regarding marking conversations as resolved. Is that something I should do or the reviewer?

[tgross35]

Thanks! I added a commit fixing the spacing for this and a few existing structs.

I'm not sure what the protocol is regarding marking conversations as resolved. Is that something I should do or the reviewer?

Different reviewers have different preferences but I prefer to resolve them myself, so I have a list of what I need to look at.

View changes since this review