Repository navigation
Conversation
clean_dcache_by_address rounded addr down to a line. It counted the lines from size alone. A range that does not start on a line missed its last line. clean_invalidate_dcache_by_address did the same. Count from the line of the first byte to the line of the last byte. The last byte's address cannot overflow. A range past the top of the address space stops at the top.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #708
The bug:
clean_dcache_by_addressroundsaddrdown to a line.sizealone.clean_invalidate_dcache_by_addressdoes the same.The fix:
dcache_lines.invalidate_dcache_by_addressis unchanged.It requires an aligned
addrandsize.For aligned input the old and the new count agree.
Overflow guard:
addr + size - 1.addr + size, up would overflow there.saturating_add).The test,
dcache_lines_cover_an_unaligned_range:The test fails without the fix:
attempt to add with overflow.Tested:
cargo test --all --exclude cortex-m-rt --exclude testsuite --features cortex-m/critical-section-single-core: passescargo clippy --all --features cortex-m/critical-section-single-core -- -D warnings: no warningscargo fmt --all -- --check: cleancargo build -p cortex-m --target thumbv7em-none-eabihf: no warningscargo build -p cortex-m --target thumbv6m-none-eabi: no warnings