Repository navigation
Conversation
Since #401 the built-in token handles both tagging and release PRs. GitHub does not start pull_request workflows for events made with the built-in token, so the next release PR would never get the required Validation check, and ci.yml's Guard expects runpod-release-please-bot as the author. Run release-please twice: the built-in token tags and creates releases (skip-github-pull-request), then the app token opens or updates the release PR (skip-github-release). The app does not need the workflows permission for PRs.
deanq
requested review from
OneAsterisk,
justinwlin and
rutvik-runpod
and
a balanced review from Copilot
and removed request for
justinwlin
October 30, 2026 22:50
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the release workflow’s separation of release creation and PR management.
No open issues 🎉
What changed in this PR
This PR restores app-authored release PRs so they can trigger required CI checks, while retaining the built-in token for release creation.
Changes:
- Splits release-please into separate release-creation and PR-management steps.
- Restores GitHub App token generation for opening and updating release PRs.
- Creates releases first and preserves the existing outputs used by publishing and Linear jobs.
| File | Description |
|---|---|
.github/workflows/release-please.yml |
Separates release and PR operations by token while preserving downstream release outputs. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#401 switched release-please to the built-in
GITHUB_TOKENfor everything. Tagging works with it. Release PRs don't:pull_requestworkflows for events made withGITHUB_TOKEN. The next release PR would never get the requiredValidationcheck, so it could only merge by admin bypass.github-actionsand got only CodeQL, no CI.ci.yml's Guard only takes the release-PR bypass when the author isrunpod-release-please-bot[bot].1.21.1 shipped because #391 had been opened by the app before #401 merged.
Change
Run release-please twice in the same job:
GITHUB_TOKENwithskip-github-pull-request: true. The app lacksworkflows, which GitHub requires to tag a commit whose history changes.github/workflows/unless a branch already points at it. After a normal release-PR merge,mainpoints at the release commit.skip-github-release: true. This is the same token that opened chore: release 1.21.1 #391.Releases run first, so a merged release PR is tagged before the PR step looks for outstanding ones.
outputs.release_created/tag_namestill come from step 1, sopypi-publishand the Linear jobs are unchanged.Both inputs exist in
release-please-action@v4(action.yml,src/index.ts).Known limit
If
mainmoves past a release commit before it is tagged (a rerun after more merges), tagging withGITHUB_TOKEN403s again. A temporary branch at the release commit fixes it, as was done for 1.21.1.Test plan
make quality-checkpasses.ci:commits don't trigger a release.runpod-release-please-botand gets the full CI run plusValidation.🤖 Generated with Claude Code