Fix .github issues: bugs, security, inconsistencies, and gaps#6884
Merged
Fix .github issues: bugs, security, inconsistencies, and gaps#6884
Conversation
- autoapproval.yml: dependabot-preview → dependabot[bot] (bot was shut down) - Issue templates: fix double-protocol Slack URLs (https:https:// → https://) - npm_lint_and_test.yml: fix path trigger typo package.lock.json → package-lock.json - remove-helped-wanted.yml: pin andymckay/labeler@master → @1.0.4 (mutable ref) - stale.yml: days-before-issue-close 9999 → -1 (proper disable value) - factory_bot_lint.yml, rake-after_party.yml: postgres 12.3 → 14.8 (match rspec) - codeql-analysis.yml: add ruby to language matrix (was JS-only) - dependabot.yml: add docker ecosystem to track base image updates - Add timeout-minutes to 9 workflows missing them (brakeman: 10, ruby_lint: 10, erb_lint: 10, spec_checker: 10, yaml_lint: 5, npm_lint: 10, factory_bot: 15, rake-after_party: 15, codeql: 30) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates CASA’s GitHub configuration to fix a few broken CI triggers/links, reduce CI supply-chain risk, align workflow environments, and add missing security scanning coverage.
Changes:
- Add job-level
timeout-minutesacross several workflows to prevent indefinite CI hangs. - Fix GitHub automation/config issues (Dependabot bot name, stale action config, workflow path trigger typo) and pin a mutable GitHub Action ref.
- Improve security/maintenance automation by enabling CodeQL for Ruby and adding Docker ecosystem updates to Dependabot.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/yaml_lint.yml | Adds a 5-minute job timeout for YAML linting. |
| .github/workflows/stale.yml | Disables issue auto-close correctly by using -1. |
| .github/workflows/spec_checker.yml | Adds a 10-minute job timeout. |
| .github/workflows/security.yml | Adds a 10-minute job timeout for Brakeman. |
| .github/workflows/ruby_lint.yml | Adds a 10-minute job timeout for StandardRB linting. |
| .github/workflows/remove-helped-wanted.yml | Pins andymckay/labeler to a fixed version instead of master. |
| .github/workflows/rake-after_party.yml | Adds timeout and aligns Postgres version to 14.8. |
| .github/workflows/npm_lint_and_test.yml | Fixes lockfile path trigger and adds a 10-minute timeout. |
| .github/workflows/factory_bot_lint.yml | Adds timeout and aligns Postgres version to 14.8. |
| .github/workflows/erb_lint.yml | Adds a 10-minute job timeout. |
| .github/workflows/codeql-analysis.yml | Adds timeout and enables CodeQL scanning for Ruby in addition to JavaScript. |
| .github/dependabot.yml | Adds Docker ecosystem updates. |
| .github/autoapproval.yml | Updates Dependabot owner identifier to dependabot[bot]. |
| .github/ISSUE_TEMPLATE/problem_validation.md | Fixes malformed Slack invite URL. |
| .github/ISSUE_TEMPLATE/flaky_test.md | Fixes malformed Slack invite URL. |
| .github/ISSUE_TEMPLATE/feature_request.md | Fixes malformed Slack invite URL. |
| .github/ISSUE_TEMPLATE/documentation.md | Fixes malformed Slack invite URL. |
| .github/ISSUE_TEMPLATE/chore.md | Fixes malformed Slack invite URL. |
| .github/ISSUE_TEMPLATE/bug_report.md | Fixes malformed Slack invite URL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bugs / Broken
autoapproval.yml:dependabot-preview→dependabot[bot](old bot was shut down years ago)https:https://→https://)npm_lint_and_test.yml: path trigger typopackage.lock.json→package-lock.json(workflow was silently never firing on lockfile changes)Security
remove-helped-wanted.yml: pinandymckay/labeler@master→@1.0.4(mutable ref is a supply-chain risk)Inconsistencies
factory_bot_lint.yml,rake-after_party.yml: Postgres12.3→14.8to matchrspec.yml(factories were testing against a different DB version than specs)Missed Opportunities
codeql-analysis.yml: addrubyto language matrix (was JS-only; free Ruby security scanning was unused)dependabot.yml: adddockerecosystem to track base image updates (ruby:4.0.2-alpine,node:24-alpine, etc.)timeout-minutesto 9 workflows that had none (could hang indefinitely and burn CI minutes):brakeman: 10 minruby_lint: 10 minerb_lint: 10 minspec_checker: 10 minyaml_lint: 5 minnpm_lint: 10 minfactory_bot_lint: 15 minrake-after_party: 15 mincodeql: 30 minOther
stale.yml:days-before-issue-close: 9999→-1(proper way to disable auto-close per stale action docs)Test plan
javascriptandrubylanguages🤖 Generated with Claude Code