DRY up admin, supervisor and volunteer spec using shared_examples#6877
Merged
compwron merged 1 commit intorubyforgood:mainfrom Apr 24, 2026
Merged
DRY up admin, supervisor and volunteer spec using shared_examples#6877compwron merged 1 commit intorubyforgood:mainfrom
compwron merged 1 commit intorubyforgood:mainfrom
Conversation
DRY up admin, supervisor and volunteer specs using shared_examples
alanparmenter
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
alanparmenter
changed the title
alanparmenter
changed the title
alanparmenter
added a commit
to alanparmenter/casa
that referenced
this pull request
Apr 25, 2026
…ec using shared_examples (rubyforgood#6877)" This reverts commit 2b1b9af.
alanparmenter
added a commit
to alanparmenter/casa
that referenced
this pull request
Apr 25, 2026
…byforgood#6877) Update devise_mailer_preview_spec.rb DRY up admin, supervisor and volunteer specs using shared_examples
alanparmenter
added a commit
to alanparmenter/casa
that referenced
this pull request
Apr 25, 2026
…ples (rubyforgood#6877)" This reverts commit 23b10c6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Related to #6874
What changed, and why?
Using
shared_examplesto remove duplication in admin, supervisor and volunteer tests.How is this tested? (please write rspec and jest tests!) 💖💪
bundle exec rspec spec/mailers/previews/devise_mailer_preview_spec.rbFeelings gif (optional)