Refactor task loading in three data_post_processing specs and fake deploy time in health_spec#6875
Open
alanparmenter wants to merge 3 commits intorubyforgood:mainfrom
Open
Refactor task loading in three data_post_processing specs and fake deploy time in health_spec#6875alanparmenter wants to merge 3 commits intorubyforgood:mainfrom
alanparmenter wants to merge 3 commits intorubyforgood:mainfrom
Conversation
…pecs, fake deploy time in health_spec, and remove conditional silencing in deployment task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Relates to #6874
(DRY Test Code as part of Test Suite Overhaul)
What changed, and why?
DRY refactor of Rake task loading: narrow loading in three
data_post_processingspecs, fake deploy time inhealth_spec, allowing removal of conditional silencing from a deployment task which is no longer called.These changes avoid repeated loading of the full Rake task suite, which prevents
Tasks::LOCK_FILESwarnings. A failed-task warning is also prevented by no longer invoking the deployment task during test runs.Source of deploy-time logic used in the test fake, and the failed-task warning:
https://github.com/alanparmenter/casa/blob/ec28640724df46436d39f7b1e7e82ef5ff673384/lib/tasks/deployment/99991023145114_store_deploy_time.rake#L8-L11
How is this tested? (please write rspec and jest tests!) 💖💪
Screenshots please :)
Before:


After:
Feelings gif (optional)