feat(browser): add :ignore_js_errors to skip known errors with js_errors - #638
Closed
oleksii-leonov wants to merge 1 commit into
Closed
oleksii-leonov wants to merge 1 commit into
oleksii-leonov wants to merge 1 commit into
Conversation
`js_errors: true` re-raises every uncaught JavaScript exception a page throws, with no way to leave some out. Some pages (especially in system specs) can throw exceptions that are benign ("ResizeObserver loop completed with undelivered notifications.", etc). Right now there is no mechanism to ignore them.
The new option `ignore_js_errors:` takes an Array of Regexp (defaults to an empty array). When `js_errors` is on and a matches the error message, the exception is dropped instead of raised.
Member
|
I don't think anything of this matters for Ferrum. I believe even js_errors belongs to Cuprite. So I would consider adding it to Cuprite rather than Ferrum |
Member
|
Mind opening on Cuprite? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
js_errors: truere-raises every uncaught JavaScript exception a page throws, with no way to leave some out. Some pages (especially in system specs) can throw exceptions that are benign ("ResizeObserver loop completed with undelivered notifications.", etc). Right now there is no mechanism to ignore them.The new option
ignore_js_errors:takes an Array of Regexp (defaults to an empty array). Whenjs_errorsis on and a matches the error message, the exception is dropped instead of raised.