Skip to content

Do not pass a raw pointer as the recursion key to rb_exec_recursive() #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
koic wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −3
Open

Do not pass a raw pointer as the recursion key to rb_exec_recursive() #1381

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions optional/capi/ext/kernel_spec.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,9 +352,8 @@ struct rb_exec_recursive_pointer_data {
};

static VALUE do_rec_pointer(VALUE obj, VALUE arg, int is_rec) {
struct rb_exec_recursive_pointer_data *obj_data = (struct rb_exec_recursive_pointer_data *)obj;
struct rb_exec_recursive_pointer_data *arg_data = (struct rb_exec_recursive_pointer_data *)arg;
if (obj_data->magic != 0x1234 || arg_data->magic != 0x1234) {
if (arg_data->magic != 0x1234) {
rb_raise(rb_eRuntimeError, "invalid recursive pointer");
}

Expand All @@ -367,7 +366,7 @@ static VALUE do_rec_pointer(VALUE obj, VALUE arg, int is_rec) {

static VALUE kernel_spec_rb_exec_recursive_with_pointer(VALUE self) {
struct rb_exec_recursive_pointer_data data = { 0x1234 };
return rb_exec_recursive(do_rec_pointer, (VALUE)&data, (VALUE)&data);
return rb_exec_recursive(do_rec_pointer, self, (VALUE)&data);
}

static void write_io(VALUE io) {
Expand Down
Loading