Skip to content

Add spec for ruby2_keywords hash passed directly as positional argument #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eregon merged 2 commits into from
Jul 11, 2026
+15 −0
Merged

Add spec for ruby2_keywords hash passed directly as positional argument #1380

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e9b998
Add spec for ruby2_keywords hash passed directly as positional argument
Jul 8, 2026
132e4e1
Define the singleton method directly and drop the call loop
Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions core/module/ruby2_keywords_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,21 @@ def proc_call(*args)
Hash.ruby2_keywords_hash?(marked).should == true
end

it "does not copy or unmark the Hash when it is passed directly as a positional argument" do
obj = Object.new
def obj.single(arg)
arg
end

h = { a: 1 }
marked = mark(**h).last
Hash.ruby2_keywords_hash?(marked).should == true

after_usage = obj.single(marked)
after_usage.should.equal?(marked)
Hash.ruby2_keywords_hash?(after_usage).should == true
end

it "applies to the underlying method and applies across aliasing" do
obj = Object.new

Expand Down
Loading