Conversation
Documentation previewCommit: |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new inherited-method path can emit a spurious duplicate-method warning.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Preserves ancestor method visibility when creating module functions.
Changes:
- Uses scoped visibility handling for module functions.
- Adds inherited and overridden method regression tests.
| File | Description |
|---|---|
| test/rdoc/parser/ruby_test.rb | Tests ancestor visibility preservation. |
| lib/rdoc/parser/ruby.rb | Changes module-function visibility handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Writer-only attributes can incorrectly shadow reader methods from farther ancestors.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Resolved since last review (1)
Comment on lines
+565
to
+566
| matches = (methods_by_name[method.name] ||= []) | ||
| next unless matches.empty? || matches.first.parent == method.parent |
st0012
marked this pull request as draft
September 21, 2026 23:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found when reviewing #1825: Calling
module_function :foocan incorrectly change the visibility of allfoomethods in the module's inheritance chain. Formodule_function's handling, the visibility change shouldn't go through ancestors.