x509attr: check for errors of sk_ASN1_TYPE_push() & use reserve call#1034
Open
ndossche wants to merge 2 commits intoruby:masterfrom
Open
x509attr: check for errors of sk_ASN1_TYPE_push() & use reserve call#1034ndossche wants to merge 2 commits intoruby:masterfrom
ndossche wants to merge 2 commits intoruby:masterfrom
Conversation
This function returns 0 on error.
rhenium
reviewed
Apr 20, 2026
| GetX509Attr(self, attr); | ||
| count = X509_ATTRIBUTE_count(attr); | ||
| /* there is no X509_ATTRIBUTE_get0_set() :( */ | ||
| #if OSSL_OPENSSL_PREREQ(3, 0, 0) |
Member
There was a problem hiding this comment.
Could you check the availability of the function in ext/openssl/extconf.rb instead?
Contributor
Author
There was a problem hiding this comment.
I'll do that after lunch. THanks, I'm relatively new to Ruby extension development so wasn't familiar with this.
This should avoid reallocations and prevent the main error condition of the push call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits.
This function returns 0 on error. The main error condition is reallocation, so use a reserve call to avoid reallocations as well.
This was found by a hybrid static-dynamic analyser that looks for inconsistent handling of error checks in bindings.