ResumableParser: use throw rather than raise for handled EOS#1031
Merged
Conversation
Since the exception will be swallowed, building a message and backtrace is just a waste of time.
byroot
commented
Jun 19, 2026
| static VALUE json_parse_any_resumable_safe(VALUE _args) | ||
| { | ||
| struct json_parse_any_args *args = (struct json_parse_any_args *)_args; | ||
| VALUE result = rb_catch_obj(args->parser, json_parse_any_resumable_safe0, _args); |
Member
Author
There was a problem hiding this comment.
It looks like on TruffleRuby, rb_catch_obj doesn't call json_parse_any_resumable_safe0 at all. Unclear why...
byroot
force-pushed
the
resumable-eos-throw
branch
from
5795ffe to
9c6d5b1
Compare
Somehow on TruffleRuby `rb_catch_obj` straight out doesn't call the passed function, acting as a noop.
byroot
force-pushed
the
resumable-eos-throw
branch
from
9c6d5b1 to
3a68749
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the exception will be swallowed, building a message and backtrace is just a waste of time.