Support block in CSV::Row#to_h#356
Open
tsymbalenkovlad wants to merge 8 commits intoruby:mainfrom
Open
Conversation
kou
reviewed
Apr 30, 2026
| new_key, new_value = if block_given? | ||
| yield(key, value) | ||
| else | ||
| [key, value] |
Member
There was a problem hiding this comment.
We don't want to create a needless temporary Array.
Could you use
if block_given?
each do |key, value|
key, value = yield(key, value)
# ...
end
else
each do |key, value|
# ...
end
endor
each do |key, value|
key, value = yield(key, value) if block_given?
# ...
end?
Author
There was a problem hiding this comment.
Thanks, that's a good one
kou
reviewed
Apr 30, 2026
Comment on lines
+342
to
+344
| row2 = CSV::Row.new(%w{A B C}, [1, 2, 3]) | ||
| hash2 = row2.to_hash { |k, v| [k, v ** 2] } | ||
| assert_equal({"A" => 1, "B" => 4, "C" => 9}, hash2) |
kou
reviewed
Apr 30, 2026
Comment on lines
+655
to
+656
| each do |key, value| | ||
| key, value = yield(key, value) if block_given? |
Member
There was a problem hiding this comment.
Ah, sorry. We need to call self[key]:
Suggested change
| each do |key, value| | |
| key, value = yield(key, value) if block_given? | |
| each do |key, _value| | |
| value = self[key] | |
| key, value = yield(key, value) if block_given? |
kou
reviewed
Apr 30, 2026
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
There was a problem hiding this comment.
Pull request overview
Adds support for passing a block to CSV::Row#to_h / #to_hash, aligning usage with Ruby’s to_h { ... } pattern and avoiding the need for row.entries.to_h { ... }.
Changes:
- Add a new test covering
CSV::Row#to_hashwith a block. - Update
CSV::Row#to_hto yield each key/value pair to an optional block before insertion.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| test/csv/test_row.rb | Adds a test for block form of to_hash. |
| lib/csv/row.rb | Implements yielding to an optional block in to_h during hash construction. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+655
to
+659
| each do |key, _value| | ||
| hash[key] = self[key] unless hash.key?(key) | ||
| value = self[key] | ||
| key, value = yield(key, value) if block_given? | ||
|
|
||
| hash[key] = value unless hash.key?(key) |
Comment on lines
655
to
+657
| each do |key, _value| | ||
| hash[key] = self[key] unless hash.key?(key) | ||
| value = self[key] | ||
| key, value = yield(key, value) if block_given? |
Comment on lines
+653
to
+659
| def to_h | ||
| hash = {} | ||
| each do |key, _value| | ||
| hash[key] = self[key] unless hash.key?(key) | ||
| value = self[key] | ||
| key, value = yield(key, value) if block_given? | ||
|
|
||
| hash[key] = value unless hash.key?(key) |
Comment on lines
+345
to
+346
| row = CSV::Row.new(%w{A B C}, [1, 2, 3]) | ||
| hash = row.to_hash { |k, v| [k, v ** 2] } |
Comment on lines
653
to
+657
| def to_h | ||
| hash = {} | ||
| each do |key, _value| | ||
| hash[key] = self[key] unless hash.key?(key) | ||
| value = self[key] | ||
| key, value = yield(key, value) if block_given? |
kou
reviewed
Apr 30, 2026
| hash = {} | ||
| each do |key, _value| | ||
| hash[key] = self[key] unless hash.key?(key) | ||
| next if hash.key?(key) |
Member
There was a problem hiding this comment.
key may be changed by yield(key, value). So we can't do this if block_given?.
How about using separated each?
if block_given?
each do |key, _value|
key, value = yield(key, self[key])
hash[key] = value unless hash.key?(key)
end
else
each do |key, _value|
hash[key] = self[key] unless hash.key?(key)
end
endThere was a problem hiding this comment.
Pull request overview
Adds block support to CSV::Row#to_h (and therefore #to_hash) to align with Ruby’s to_h { ... } conversion pattern, so callers don’t need to go through row.entries.to_h { ... }.
Changes:
- Extend
CSV::Row#to_hto accept an optional block that transforms each (key, value) pair before insertion. - Document the new block form in
CSV::Row#to_h’s RDoc. - Add a unit test exercising
to_hashwith a block.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/csv/test_row.rb | Adds coverage for CSV::Row#to_hash accepting a block. |
| lib/csv/row.rb | Implements and documents block support for CSV::Row#to_h/#to_hash. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
662
to
+668
| each do |key, _value| | ||
| hash[key] = self[key] unless hash.key?(key) | ||
| next if hash.key?(key) | ||
|
|
||
| value = self[key] | ||
| key, value = yield(key, value) if block_given? | ||
|
|
||
| hash[key] = value |
| next if hash.key?(key) | ||
|
|
||
| value = self[key] | ||
| key, value = yield(key, value) if block_given? |
Comment on lines
+345
to
+347
| row = CSV::Row.new(%w{A A B C}, [1, 2, 2, 3]) | ||
| hash = row.to_hash { |k, v| [k, v**2] } | ||
| assert_equal({"A" => 1, "B" => 4, "C" => 9}, hash) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It will be consistent with Ruby's method, otherwise it has to be like
row.entries.to_h { ... }