Repository navigation
feat: discover and authenticate the Engine HTTP API with mTLS - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certificate clients can use Engine inventory and SSE/WebSocket watches through an explicitly advertised mTLS HTTP origin. Each client anonymously discovers and caches the HTTPS origin, coalesces concurrent discovery, validates the project binding, and closes outstanding discovery on shutdown. Ordinary token behavior and existing device configuration remain compatible.
Discovery never sends the device certificate or a bearer token and always verifies server TLS. Documentation identifies the Python HTTP transport boundary and adds an opt-in real Engine inventory check.
Validation: ruff, formatting and mypy pass; 172 tests pass (6 existing opt-in skips), including real local TLS, concurrent discovery, anonymous requests, cancellation, closure and certificate inventory/watch paths.