Repository navigation
test(vscode): narrow upstream-internal coupling in tests - #123
Merged
Merged
Conversation
Assert user-visible behavior instead of upstream package internals that `src/` does not depend on: - smoke: describe only that the project's `@rslint/core` runs a plugin rule and produces a diagnostic; drop the frame/ESTree/wire wording. - monorepo: copy the whole resolved `@rslint/core` package for the second physical core, so the fixture no longer encodes the package's `dist` layout. - jsconfig: drop the assertion that an ignored nested config is never re-evaluated (upstream scheduling); keep the visible outcome and document the deviation. - comments and assertion messages: remove Go/server/tsgo/Program/catalog premises and name the observed behavior instead. - plugin-host failure fixture: record the worker-thread premise as a known exception to the rule. Document the rule in `packages/vscode/AGENTS.md` testing conventions.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests may depend on an upstream internal only when
packages/vscode/srcdepends on the same detail. This rule is now inpackages/vscode/AGENTS.md, and all tests inpackages/vscodewere scanned against it.Kept on purpose:
jsconfig.test.tsandnoconfig.test.ts, which stop a negative assertion passing vacuously.isMainThreadcheck in theplugin-host-failurefixture, documented as a known exception: no public surface can fail only the plugin host.Evidence
pluginLintrequest, so@rslint/core0.10.0 failed it withERR_INVALID_ARG_TYPEalthough users saw no change (fixed in test(e2e): drive the plugin-host smoke test through the public API #122, whose comments still described the wire format).After: no test code or comment in
packages/vscodementionsframe.Run on macOS arm64, at this commit:
pnpm lintpnpm test:unitpnpm test:e2e smokepnpm test:e2e lintThe
vscodeandrstestslices, and Windows, were not run locally. CI covers them. The Windows path of the monorepo copy depends on that run.Merge Danger
Door: two-way
Blast Radius: tests
No
srcchange. One regression guard is removed on purpose: re-evaluation of an ignored nested config is no longer asserted in this repo.