fix: hash the manifest version with sha256 for FIPS hosts - #126
Merged
Conversation
md5 is unavailable when Node runs on a FIPS-enabled machine, so the manifest version digest threw during builds there. sha256 is FIPS-approved and the version only needs to be a short, stable content digest. Fixes #124 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
Contributor
Benchmark results
|
Merging this PR will not alter performance
Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The browser manifest version was an md5 digest, and md5 is unavailable when Node runs on a FIPS-enabled machine, so builds threw there (#124). Use sha256, which is FIPS-approved; the version only needs to be a short, stable content digest. The other two hashes in the plugin were already sha256 and sha384.
Existing deployments see the manifest file name change once. Patch changeset included.
Fixes #124
Verification
pnpm typecheck,pnpm build, and the manifest unit suites pass.🤖 Generated with Claude Code