support ""ros2 action info (-v)" with ActionEndpointInfo.#1262
support ""ros2 action info (-v)" with ActionEndpointInfo.#1262fujitatomoya wants to merge 3 commits into
Conversation
Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
|
Tick the box to add this pull request to the merge queue (same as
|
There was a problem hiding this comment.
Pull request overview
This PR enhances the ros2 action info command to align more closely with the verbosity and endpoint-detail capabilities of ros2 topic info -v / ros2 service info -v, by leveraging ActionEndpointInfo over the ros2cli daemon/XML-RPC boundary.
Changes:
- Extend
ros2 action infoto print the action type (Type: ...) in the default output and add-v/--verboseto print detailed endpoint info. - Add XML-RPC marshalling support for
rclpy.endpoint_info.ActionEndpointInfoand expose new daemon RPC methods for action endpoint info and action client/server counts. - Add/extend CLI and daemon tests to validate the new action info output and RPC surfaces.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ros2cli/test/test_ros2cli_daemon.py | Adds daemon-level tests for action endpoint info retrieval and action client/server counting. |
| ros2cli/ros2cli/xmlrpc/marshal/rclpy.py | Registers XML-RPC marshalling/unmarshalling support for ActionEndpointInfo. |
| ros2cli/ros2cli/daemon/init.py | Exposes new daemon RPC functions for action endpoint info + action client/server counts. |
| ros2action/test/test_cli.py | Updates ros2 action info tests to expect a Type: line and adds verbose-mode assertions. |
| ros2action/ros2action/verb/info.py | Implements Type: printing and --verbose/-v detailed endpoint output for ros2 action info. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
|
Pulls: ros2/rcl#1326, ros2/rclcpp#3209, ros2/rclpy#1697, #1262 |
|
a couple of CI jobs are halted, restarting with |
|
Pulls: ros2/rcl#1326, ros2/rclcpp#3209, ros2/rclpy#1697, #1262 |
ahcorde
left a comment
There was a problem hiding this comment.
I can see some failures in windows and rhel related with this PR, do you mind to take a look ?
Description
Closes #1210 and replaces #1220
Fixes # (issue)
Is this user-facing behavior change?
Noyes notros2 action infocan print the same format withros2 topic/service info.Did you use Generative AI?
Yes, Claude Fable.
Additional Information