Skip to content

support ""ros2 action info (-v)" with ActionEndpointInfo.#1262

Open
fujitatomoya wants to merge 3 commits into
rollingfrom
ros2cli/issues/1210
Open

support ""ros2 action info (-v)" with ActionEndpointInfo.#1262
fujitatomoya wants to merge 3 commits into
rollingfrom
ros2cli/issues/1210

Conversation

@fujitatomoya

@fujitatomoya fujitatomoya commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

Description

Closes #1210 and replaces #1220

Fixes # (issue)

Is this user-facing behavior change?

No yes not ros2 action info can print the same format with ros2 topic/service info.

Did you use Generative AI?

Yes, Claude Fable.

Additional Information

Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
@mergify

mergify Bot commented Jul 19, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the ros2 action info command to align more closely with the verbosity and endpoint-detail capabilities of ros2 topic info -v / ros2 service info -v, by leveraging ActionEndpointInfo over the ros2cli daemon/XML-RPC boundary.

Changes:

  • Extend ros2 action info to print the action type (Type: ...) in the default output and add -v/--verbose to print detailed endpoint info.
  • Add XML-RPC marshalling support for rclpy.endpoint_info.ActionEndpointInfo and expose new daemon RPC methods for action endpoint info and action client/server counts.
  • Add/extend CLI and daemon tests to validate the new action info output and RPC surfaces.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ros2cli/test/test_ros2cli_daemon.py Adds daemon-level tests for action endpoint info retrieval and action client/server counting.
ros2cli/ros2cli/xmlrpc/marshal/rclpy.py Registers XML-RPC marshalling/unmarshalling support for ActionEndpointInfo.
ros2cli/ros2cli/daemon/init.py Exposes new daemon RPC functions for action endpoint info + action client/server counts.
ros2action/test/test_cli.py Updates ros2 action info tests to expect a Type: line and adds verbose-mode assertions.
ros2action/ros2action/verb/info.py Implements Type: printing and --verbose/-v detailed endpoint output for ros2 action info.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ros2action/ros2action/verb/info.py
Comment thread ros2action/ros2action/verb/info.py
Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
Comment thread ros2action/ros2action/verb/info.py Outdated
Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
@fujitatomoya

Copy link
Copy Markdown
Collaborator Author

Pulls: ros2/rcl#1326, ros2/rclcpp#3209, ros2/rclpy#1697, #1262
Gist: https://gist.githubusercontent.com/fujitatomoya/25af40ef2cbead2e0d78b131f3baccbf/raw/799fbf9be74c92398265c46702a25e9b46e9c0b3/ros2.repos
BUILD args: --packages-up-to rcl_action rclcpp_action rclpy ros2cli ros2action
TEST args: --packages-select rcl_action rclcpp_action rclpy ros2cli ros2action
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19923

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya

Copy link
Copy Markdown
Collaborator Author

a couple of CI jobs are halted, restarting with ros-ci-for-pr --pulls ros2/rcl#1326 ros2/rclcpp#3209 ros2/rclpy#1697 ros2/ros2cli#1262 --packages rcl_action rclcpp_action rclpy ros2cli ros2action --build -c --only-fixes-test

@fujitatomoya

Copy link
Copy Markdown
Collaborator Author

Pulls: ros2/rcl#1326, ros2/rclcpp#3209, ros2/rclpy#1697, #1262
Gist: https://gist.githubusercontent.com/fujitatomoya/465889284b527b2c339cbef7dbc3d756/raw/799fbf9be74c92398265c46702a25e9b46e9c0b3/ros2.repos
BUILD args: --packages-up-to rcl_action rclcpp_action rclpy ros2cli ros2action
TEST args: --packages-select rcl_action rclcpp_action rclpy ros2cli ros2action
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19925

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see some failures in windows and rhel related with this PR, do you mind to take a look ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ros2 action info output is not consistent with ros2 topic/service info

3 participants