Apply a dark "scrim" when drawer is open#223
Open
cooperka wants to merge 1 commit intoroot-two:masterfrom
Open
Apply a dark "scrim" when drawer is open#223cooperka wants to merge 1 commit intoroot-two:masterfrom
cooperka wants to merge 1 commit intoroot-two:masterfrom
Conversation
Author
|
Hi @rt2zz, would you mind taking a look at this PR please? It's small but useful :) |
Author
|
@rt2zz ping |
cooperka
changed the title
styles.mainScrim when drawer is open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When used as suggested in the example docs, this adds a dark shadow over the main content when the drawer is open. Using a scrim is suggested in Google's Material Design guide, and is done in many popular apps.
It would be awesome if we could animate this, but I also don't want to bog anything down performance-wise. It would be simple to add a new state item e.g.
openRatio, and apply the scrim incrementally based on how far open the drawer is. Just let me know if you'd prefer that I implement this!