Skip to content

add tapToClose flag#193

Open
warmhug wants to merge 1 commit intoroot-two:masterfrom
warmhug:patch-1
Open

add tapToClose flag#193
warmhug wants to merge 1 commit intoroot-two:masterfrom
warmhug:patch-1

Conversation

@warmhug
Copy link
Copy Markdown

@warmhug warmhug commented Jul 18, 2016

No description provided.

@rt2zz
Copy link
Copy Markdown
Member

rt2zz commented Jul 18, 2016

I am a bit uncomfortable overloading the type argument close (the type argument to be honest was a bad api design on my part to begin with).

Can you explain why you need tapToClose flag passed to the onClose handler? Perhaps there is a more direct solution.

@warmhug
Copy link
Copy Markdown
Author

warmhug commented Jul 19, 2016

I use open to control the drawer's "open/close" state. when i setState({ open: false }), will trigger onClose function, but it also trigger onClose on setting tapToClose. So, I can't distinguish between the two. Thus, i can not control the state totally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants