BenchMarking for Codegen and CodegenNoGrad() - #282
Closed
abhigyan-ach wants to merge 1 commit into
Closed
Conversation
Member
|
I was wondering what is the fate of this PR? |
guitargeek
added a commit
that referenced
this pull request
Sep 4, 2026
Benchmark the automatic-differentiation "codegen" evaluation backend and its "codegen_no_grad" variant (numeric gradient) alongside the existing Legacy, CPU, and CUDA configurations. The GausXS model gets no codegen variants because its normalization requires a multi-dimensional numeric integral that the codegen backend does not support. The BDecay benchmarks in RooFitUnBinnedBenchmarks.cxx are also left unchanged, since RooBMixDecay, RooGaussModel, and RooAddModel have no codegen translate functions yet. This supersedes the corresponding part of PR #282.
Contributor
|
Thank you @abhigyan-ach for this contribution, and apologies that it went unanswered for so long! Benchmarking the codegen (AD) backend in these fit benchmarks was indeed the idea, and it is now implemented in #310, which adds working Closing in favor of #310. Thanks again for pushing on the AD benchmarking front early on! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added functionality to test benchmarks for codegen and codegen_no_grad evaluation backends. There are currently some issues with the benchmarks in benchRooFitBackEnds.cxx, RooFitUnbinnedBenchmarks.cxx and RooFitBinnedBenchMarks.
@guitargeek