[tmva] Detach TMVA::DNN::TCpuTensor from TMVA::Experimental::RTensor - #23430
Merged
Merged
Conversation
TCpuTensor publicly derived from the experimental RTensor class. With RTensor being at the verge of getting deprecated from the public interface, TCpuTensor becomes standalone. It absorbs the storage (fShape, fStrides, fSize, fLayout, fData, fContainer), the stride/size helpers, and the accessors that DNN code uses (GetShape, GetStrides, GetSize, GetData, GetContainer, GetMemoryLayout, ReshapeInplace), with the exact same semantics as before. The unused inherited parts (iterators, Copy, Slice, Transpose, Squeeze, ExpandDims) are not carried over. The MemoryLayout enum that was defined in `RTensor.hxx` is now owned by the DNN code as `TMVA::DNN::MemoryLayout` in CpuTensor.h; the CUDA headers keep their pre-existing local copy. All non-CUDA call sites (TCpu, MethodDL and the DNN test headers) are migrated accordingly. Also drop the disabled RTensor conversion block in CudaTensor.cu, the commented-out references to RTensor.hxx in Reference.h and CudaTensor.h, and two dead 'using namespace TMVA::Experimental' declarations in test headers that only resolved through transitive RTensor includes.
Test Results 23 files 23 suites 3d 14h 40m 28s ⏱️ For more details on these failures, see this check. Results for commit a5b64dd. ♻️ This comment has been updated with latest results. |
dpiparo
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TCpuTensor publicly derived from the experimental RTensor class. With RTensor being at the verge of getting deprecated from the public interface, TCpuTensor becomes standalone. It absorbs the storage (fShape, fStrides, fSize, fLayout, fData, fContainer), the stride/size helpers, and the accessors that DNN code uses (GetShape, GetStrides, GetSize, GetData, GetContainer, GetMemoryLayout, ReshapeInplace), with the exact same semantics as before. The unused inherited parts (iterators, Copy, Slice, Transpose, Squeeze, ExpandDims) are not carried over.
The MemoryLayout enum that was defined in
RTensor.hxxis now owned by the DNN code asTMVA::DNN::MemoryLayoutin CpuTensor.h; the CUDA headers keep their pre-existing local copy. All non-CUDA call sites (TCpu, MethodDL and the DNN test headers) are migrated accordingly.Also drop the disabled RTensor conversion block in CudaTensor.cu, the commented-out references to RTensor.hxx in Reference.h and CudaTensor.h, and two dead 'using namespace TMVA::Experimental' declarations in test headers that only resolved through transitive RTensor includes.