[Python][UHI] Accept objects with _to_uhi_ in the constructor - #23408
Merged
Merged
Conversation
Test Results 23 files 23 suites 3d 16h 17m 52s ⏱️ For more details on these failures, see this check. Results for commit 873f180. ♻️ This comment has been updated with latest results. |
vepadulano
approved these changes
Sep 21, 2026
vepadulano
left a comment
vepadulano
left a comment
Member
There was a problem hiding this comment.
Given it's already possible to achieve the same by constructing an histogram with the output of from_uhi, I think this is a nice shortcut saving the user a few characters and a mental jump. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
ROOT.TH1*(obj)now accepts any object with a_to_uhi_method next to the raw UHI dict. The object is converted to its UHI dict and the rest of the code path remains unchanged.THis feature is also provided by other UHI-comaptible libraries (see scikit-hep/hist#719 and scikit-hep/boost-histogram#1191 for example).