Skip to content

[core] deprecate compiledata.h - #23396

Open
ferdymercury wants to merge 4 commits into
root-project:masterfrom
ferdymercury:compdata
Open

ferdymercury wants to merge 4 commits into
root-project:masterfrom
ferdymercury:compdata

Conversation

@ferdymercury

Copy link
Copy Markdown
Collaborator

This Pull request:

Changes or fixes:

Header was kind of broken, since header guards were missing.
Luckily it was only used by cxx files once.
Plus naming problems.

In a later step we can privatize it, and later skip this header all the way and go towards a CMake definition target #23291

@ferdymercury ferdymercury added the skip code analysis Skip the code analysis CI steps for this PR, including verifying clang-formatting and running Ruff. label Sep 16, 2026

@pcanal pcanal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the naming problem. I find this file useful for debugging purposes of user installation. Unless we also publish the information in a 'easy/clear' to find way in a move to CMake based, I don't see that move as a beneficial move.

I.e. I would not mind a renamed and improvement but I would not deprecate it (although there is a point to be made that it is an internal details and should not rely upon/used in user code).

@ferdymercury

Copy link
Copy Markdown
Collaborator Author

Besides the naming problem. I find this file useful for debugging purposes of user installation. Unless we also publish the information in a 'easy/clear' to find way in a move to CMake based, I don't see that move as a beneficial move.

I.e. I would not mind a renamed and improvement but I would not deprecate it (although there is a point to be made that it is an internal details and should not rely upon/used in user code).

This could maybe go into etc/ subfolder as a .txt file, or alternatively into info by RootTargets.cmake

But we could decide that later, after telling people to not include it in their downstream code?

@pcanal

pcanal commented Sep 16, 2026

Copy link
Copy Markdown
Member

This could maybe go into etc/ subfolder as a .txt file, or alternatively into info by RootTargets.cmake

With any solution, this file (or its successor) must be the source of truth (as used to build up the ACLiC command line), if it is "only" a duplicata the likelihood that over time it drift to be inaccurate is extremely high.

Comment thread cmake/unix/compiledata.sh Outdated
@ferdymercury
ferdymercury requested a review from pcanal September 16, 2026 21:42
@ferdymercury ferdymercury added this to the 6.42.00 milestone Sep 16, 2026
@github-actions

Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 18h 47m 3s ⏱️
 3 879 tests  3 877 ✅ 0 💤 2 ❌
76 265 runs  76 263 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 0d5a5ef.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip code analysis Skip the code analysis CI steps for this PR, including verifying clang-formatting and running Ruff.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants