[core] rename libRint.so to libROOTRint.so - #23380
Open
ferdymercury wants to merge 8 commits into
Open
ferdymercury wants to merge 8 commits into
ferdymercury wants to merge 8 commits into
Conversation
Test Results 23 files 23 suites 3d 12h 28m 50s ⏱️ For more details on these failures, see this check. Results for commit 59acbaa. ♻️ This comment has been updated with latest results. |
pcanal
reviewed
Sep 16, 2026
ferdymercury
commented
Sep 16, 2026
ferdymercury
commented
Sep 16, 2026
ferdymercury
commented
Sep 16, 2026
pcanal
reviewed
Sep 16, 2026
pcanal
reviewed
Sep 16, 2026
Co-authored-by: Philippe Canal <pcanal@fnal.gov>
ferdymercury
commented
Sep 16, 2026
ferdymercury
commented
Sep 16, 2026
as suggested by pcanal
pcanal
reviewed
Sep 16, 2026
pcanal
reviewed
Sep 16, 2026
pcanal
reviewed
Sep 16, 2026
| ROOT_BUILD_OPTION(spectrum ON "Enable support for TSpectrum") | ||
| ROOT_BUILD_OPTION(sqlite ON "Enable support for SQLite") | ||
| ROOT_BUILD_OPTION(ssl ON "Enable support for SSL encryption via OpenSSL") | ||
| ROOT_BUILD_OPTION(symlink_libs ON "Build backward compatibility symlinks for historical libnames (libCore.so instead of libROOTCore.so).") |
Member
There was a problem hiding this comment.
@hageboeck @dpiparo Did we decide/agree on a spelling rule for the new names?
Collaborator
Author
There was a problem hiding this comment.
and backup rule in case there is clash, like currently there is already Hist and ROOTHist, so Hist would need to become ROOTHisto or sth like that.
ferdymercury
marked this pull request as ready for review
September 16, 2026 22:21
ferdymercury
requested review from
dpiparo,
guitargeek and
vepadulano
as code owners
September 16, 2026 22:21
Collaborator
Author
|
On some platforms (maybe those with modules_off ?), there seems to be some problems with AutoLoad |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Starts to fix #10985
Related attempt: #11077
This in an experiment of @hageboeck 's proposal in slide 18 of https://indico.cern.ch/event/1708099/contributions/7184184/attachments/3315365/5934462/26.07.16_UpdateOnROOT7.pdf
Which will be fundamental for Debian packaging.
I just chose a smallish library, to get comments and see if strategy aligns.
If it looks good I could continue with more, or hand it over to any ROOT dev if you prefer.