Skip to content

[ci] Add Debian testing (with builtin_llvm=OFF) - #23372

Open
ferdymercury wants to merge 4 commits into
root-project:masterfrom
ferdymercury:patch-24
Open

ferdymercury wants to merge 4 commits into
root-project:masterfrom
ferdymercury:patch-24

Conversation

@ferdymercury

@ferdymercury ferdymercury commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

This Pull request:

Changes or fixes:

Fedora CI has rawhide, So Debian CI has testing for analogy. But no need to merge this, it can stay as a draft PR for individual testing of new packages. New package to test will be libmathtext-dev.

It's like Debian13, but tests the new libcivetweb-dev package, so builtin_civetweb can be OFF. fyi @linev confirmed that new Debian civetweb will be compatible.

First results not too bad: only 13 tests failing with builtin_llvm=OFF

Merge first

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@ferdymercury

ferdymercury commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator Author

@alja @osschar maybe you know why debiantesting CI build fails with a heap error? https://github.com/root-project/root/actions/runs/34956369673/job/104339538592?pr=23372

@ferdymercury ferdymercury added the skip code analysis Skip the code analysis CI steps for this PR, including verifying clang-formatting and running Ruff. label Sep 15, 2026
@ferdymercury ferdymercury reopened this Sep 16, 2026
@github-actions

Copy link
Copy Markdown

Test Results

2 617 tests   2 617 ✅  1h 16m 20s ⏱️
    1 suites      0 💤
    1 files        0 ❌

Results for commit 906d28a.

It's like Debian13, but tests the new libcivetweb-dev package, so builtin_civetweb can be OFF.

[ci] disable pyspark on Debiantesting

CMake Error at cmake/modules/FindPySpark.cmake:34 (message):
    Currently, there are no Spark versions that support Java version greater
    than 21.  Found Java version 25.0.4.1.
  Call Stack (most recent call first):
    cmake/modules/SearchInstalledSoftware.cmake:1259 (find_package)
    CMakeLists.txt:131 (include)
…in_llvm=OFF

Alternative to root-project#23160 that does not require any upstream or downstream patches

In ROOT, for builtin_llvm=OFF we have the sequence

```
find_package(LLVM) # searchs for system package, which sets DYLIB to ON
set(LLVM_LINK_LLVM_DYLIB OFF) # override DYLIB to OFF, we want static
add_subdirectory(clang) # this will call find_package LLVM again
```

See root-project#13420

Since LLVM22 though, this fails:
Even if we call for a second time `set(LLVM_LINK_LLVM_DYLIB OFF)` after the `add_subdirectory` line, it's not enough, because that variable was ON all throughout the child `clang/CMakeLists.txt` and has already configured some stuff with the wrong flag.

Avoid the issue by preventing the double-search of LLVM and thus the double overwrite, by temporarily overwriting the find_package(LLVM) calls.

Fixes root-project#18387
Fixes root-project#23155
@ferdymercury ferdymercury changed the title [ci] Add Debian testing [ci] Add Debian testing (with builtin_llvm=OFF) Sep 16, 2026
@ferdymercury
ferdymercury marked this pull request as ready for review September 16, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:squash on merge skip code analysis Skip the code analysis CI steps for this PR, including verifying clang-formatting and running Ruff.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant