Conversation
There is currently no clear API use case for these bookkeeping methods, so we remove them from the public API until it arises.
enirolf
requested review from
couet,
dpiparo,
jblomer and
silverweed
as code owners
September 14, 2026 12:24
vepadulano
approved these changes
Sep 14, 2026
Test Results 23 files 23 suites 3d 19h 16m 6s ⏱️ For more details on these failures, see this check. Results for commit 134c0e5. ♻️ This comment has been updated with latest results. |
jblomer
approved these changes
Sep 14, 2026
They're only relevant there now, after removing the public getters from RNTupleProcessor.
silverweed
approved these changes
Sep 15, 2026
| std::vector<std::unique_ptr<RNTupleProcessor>> fInnerProcessors; | ||
| std::vector<ROOT::NTupleSize_t> fInnerNEntries; | ||
|
|
||
| ROOT::NTupleSize_t fLastLoadedEntry = 0; //< Last (global) entry number that was loaded |
vepadulano
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently no clear API use case for these bookkeeping methods (nor have they been used so far for the Darwin/FastFrames evaluations), so we remove them from the public API until it arises.