Conversation
vepadulano
approved these changes
Sep 14, 2026
Test Results 23 files 23 suites 3d 20h 5m 27s ⏱️ For more details on these failures, see this check. Results for commit 7583d06. ♻️ This comment has been updated with latest results. |
jblomer
approved these changes
Sep 14, 2026
jblomer
left a comment
jblomer
left a comment
Contributor
There was a problem hiding this comment.
I think it would be nice making this string a constant.
This is more consistent with other internal fields (e.g. in RDataFrame), and further reduces the risk of ambiguity compared to just "_join".
enirolf
force-pushed
the
ntuple-proc-join-field-name
branch
from
September 15, 2026 07:36
c55a42e to
7583d06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more consistent with other internal fields (e.g. in RDataFrame), and further reduces the risk of ambiguity compared to just "_join".