Skip to content

[core] no longer provide transitive unused includes - #23358

Draft
ferdymercury wants to merge 2 commits into
root-project:masterfrom
ferdymercury:lessinc
Draft

ferdymercury wants to merge 2 commits into
root-project:masterfrom
ferdymercury:lessinc

Conversation

@ferdymercury

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

Copy link
Copy Markdown

Test Results

    23 files      23 suites   3d 20h 13m 36s ⏱️
 3 878 tests  3 878 ✅ 0 💤 0 ❌
80 076 runs  80 076 ✅ 0 💤 0 ❌

Results for commit a2988e2.

@linev

linev commented Sep 14, 2026

Copy link
Copy Markdown
Member

R_LESS_INCLUDES was introduced long time ago, but was never active in installed ROOT.
One should be careful with such changes - it can break compilation of user code without any warnings
And inexperienced users may fail to fix such simple compilation problem.

Maybe such change will be fine after ROOT 6.44 as part of ROOT7 changes.

@ferdymercury
ferdymercury marked this pull request as draft September 14, 2026 15:43
@ferdymercury

Copy link
Copy Markdown
Collaborator Author

Thanks for the feedback!

And inexperienced users may fail to fix such simple compilation problem

From my latest experience, inexperienced users ask first LLMs before asking in the ROOT user forum, and they will get most probably the right answer.

Maybe such change will be fine after ROOT 6.44 as part of ROOT7 changes.

If that's the case, then I can mark this one as draft and suggest instead: #23366

@linev

linev commented Sep 14, 2026

Copy link
Copy Markdown
Member

From my latest experience, inexperienced users ask first LLMs before asking in the ROOT user forum, and they will get most probably the right answer.

I face a lot of users who fail with such simple problem. And they just jump back to previous ROOT version or even stayed with ROOT5 until 2024 - 10 years after ROOT6 release.

@ferdymercury

Copy link
Copy Markdown
Collaborator Author

after ROOT 6.44

Could you create a label "ROOT6.46" or "ROOT7" so that I can mark this PR with that one? Thanks in advance!

@silverweed

Copy link
Copy Markdown
Contributor

Could you create a label "ROOT6.46" or "ROOT7" so that I can mark this PR with that one? Thanks in advance!

@dpiparo

(I would be in favor of this change for ROOT7)

@hageboeck hageboeck added this to the 6.46/7 milestone Sep 15, 2026
@hageboeck

Copy link
Copy Markdown
Member

after ROOT 6.44

Could you create a label "ROOT6.46" or "ROOT7" so that I can mark this PR with that one? Thanks in advance!

I thought it better to make it a milestone; done now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants