Skip to content

[core] deprecate implementation detail zip headers since there is RZip public interface - #23271

Merged
dpiparo merged 4 commits into
root-project:masterfrom
ferdymercury:zipdepr
Sep 11, 2026
Merged

dpiparo merged 4 commits into
root-project:masterfrom
ferdymercury:zipdepr

Conversation

@ferdymercury

@ferdymercury ferdymercury commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

This Pull request:

Changes or fixes:

This is necessary step before #23270

At the moment, the headers are just copy-pasted where used. Once they are fully removed in 6.46, one can recreate them in a private folder. I wanted to prevent now creating them with the same name in two different folders which calls for problems.

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

Test Results

    23 files      23 suites   3d 20h 53m 14s ⏱️
 3 878 tests  3 876 ✅ 0 💤 2 ❌
79 885 runs  79 883 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 85f5d5e.

♻️ This comment has been updated with latest results.

@ferdymercury
ferdymercury marked this pull request as ready for review September 6, 2026 11:08
@jblomer jblomer self-assigned this Sep 6, 2026
@ferdymercury ferdymercury added the skip code analysis Skip the code analysis CI steps for this PR, including verifying clang-formatting and running Ruff. label Sep 8, 2026
Comment thread core/zip/src/RZip.cxx

@pcanal pcanal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine to deprecate those headers. Thanks.

Comment thread builtins/zip/ZInflate.c
Comment thread builtins/zip/ZInflate.c
Comment thread core/lz4/src/ZipLZ4.cxx
Comment thread core/lzma/src/ZipLZMA.c
Comment thread core/zip/src/RZip.cxx
Comment thread core/zip/src/RZip.cxx Outdated
Comment thread core/zip/src/RZip.cxx
Comment thread core/zstd/src/ZipZSTD.cxx
@ferdymercury
ferdymercury force-pushed the zipdepr branch 3 times, most recently from 59547c3 to 3005777 Compare September 10, 2026 17:31

@pcanal pcanal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@ferdymercury

Copy link
Copy Markdown
Collaborator Author

CI failures seem unrelated

@dpiparo
dpiparo merged commit c8d3852 into root-project:master Sep 11, 2026
32 of 35 checks passed
@ferdymercury
ferdymercury deleted the zipdepr branch September 11, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip code analysis Skip the code analysis CI steps for this PR, including verifying clang-formatting and running Ruff.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants