[RF] Implement RooMomentMorphFuncND::compileForNormSet()#22105
Open
guitargeek wants to merge 3 commits intoroot-project:masterfrom
Open
[RF] Implement RooMomentMorphFuncND::compileForNormSet()#22105guitargeek wants to merge 3 commits intoroot-project:masterfrom
guitargeek wants to merge 3 commits intoroot-project:masterfrom
Conversation
guitargeek
changed the title
Transform the RooMomentMorphFuncND instance to an expended computation graph that can be evaluated by the `RooFit::Evaluator` without missing some internal RooAbsArgs that could be cached.
This is a reoccuring pattern that merits its own helper function.
…paths In the Evaluator backend, the compile-time analytical-integral construction, doEval, and analyticalIntegralWN each queried `_cacheMgr` with a different (or null/empty) RooArgSet, so the heavy cache content was rebuilt on the first fit step instead of reusing the slot populated during NLL setup. Pin a stable `_compiledNormSet` on the cloned pdf in compileForNormSet for doEval to use, and let analyticalIntegralWN fall back to `anaVars` when the stored `normSet2` is empty so its key mirrors getAnalyticalIntegralWN's. All three paths now hit the same slot. Fixes the stressRooFit -b cpu -n 47 slowdown vs the legacy backend (RooIntegralMorph fit with setCacheAlpha(true)).
guitargeek
force-pushed
the
morphing_slowdown
branch
from
fa6de24 to
d7f2c5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transform the RooMomentMorphFuncND instance to an expended computation graph that can be evaluated by the
RooFit::Evaluatorwithout missing some internal RooAbsArgs that could be cached.Closes #22070.