Skip to content

[v640][RF] Backport of chi-square and RooONNXFunc fixes, update xRooFit for the release#22102

Merged
guitargeek merged 3 commits intoroot-project:v6-40-00-patchesfrom
guitargeek:bp_1
Apr 29, 2026
Merged

[v640][RF] Backport of chi-square and RooONNXFunc fixes, update xRooFit for the release#22102
guitargeek merged 3 commits intoroot-project:v6-40-00-patchesfrom
guitargeek:bp_1

Conversation

@guitargeek
Copy link
Copy Markdown
Contributor

Backport recent RooFit commits to the release branch.

guitargeek and others added 3 commits April 29, 2026 16:19
The `createChi2()` / `chi2FitTo()` so far always went through the legacy
`RooChi2Var`. This commit wires them up to the same evaluation pipeline
that `createNLL()` uses, so all of Cpu, Cuda, Codegen and CodegenNoGrad
backend now work for chi-squared fits.

(cherry picked from commit f6bb68f)
This resyncs the xRooFit external developments with those in ROOT

(cherry picked from commit c695dfb)
  * copying `_funcName` was forgotten

  * `d_inputFlt` should start from zero so the derivatives get correctly
    accumulated (noticed when running benchmarks and tests)

(cherry picked from commit 498c038)
@guitargeek guitargeek self-assigned this Apr 29, 2026
@github-actions
Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 12h 32m 57s ⏱️
 3 849 tests  3 849 ✅ 0 💤 0 ❌
76 927 runs  76 927 ✅ 0 💤 0 ❌

Results for commit 1ba3269.

@guitargeek guitargeek merged commit 0177de2 into root-project:v6-40-00-patches Apr 29, 2026
32 of 33 checks passed
@guitargeek guitargeek deleted the bp_1 branch April 29, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants