[ntuple] Merger: skip a buffer copy when out compression is 0#22096
Merged
silverweed merged 1 commit intoroot-project:masterfrom Apr 30, 2026
Merged
Conversation
silverweed
changed the title
silverweed
force-pushed
the
ntuple_merge_skipcopy_recompress
branch
from
d89962c to
37595ee
Compare
silverweed
force-pushed
the
ntuple_merge_skipcopy_recompress
branch
from
37595ee to
5e8098d
Compare
Test Results 22 files 22 suites 3d 11h 36m 11s ⏱️ Results for commit 5e8098d. |
hahnjo
approved these changes
Apr 29, 2026
Member
hahnjo
left a comment
hahnjo
left a comment
There was a problem hiding this comment.
LGTM. Would have been good to spell out the change to std::byte and potentially have it in a separate commit...
jblomer
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When recompressing pages we can skip the creation of the zip auxiliary buffer if we don't need to actually zip back the pages. This also saves a memcpy per page in that case.
Checklist: