Skip to content

fix: avoid the E_STRICT deprecation on PHP 8.4+ #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adriandmitroca wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: avoid the E_STRICT deprecation on PHP 8.4+ #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@ final class Plugin extends AbstractSingleton
{
public const VERSION = '3.3.1';

/**
* The value of E_STRICT. PHP 8.4 deprecated the constant itself, so reading it raises an E_DEPRECATED notice on
* every request. PHP has not raised E_STRICT errors since 8.0, but saved settings may still hold this value.
*/
public const E_STRICT = 2048;

/**
* Configuration array for Rollbar.
*
Expand Down Expand Up @@ -230,7 +236,7 @@ public static function buildIncludedErrno(int $cutoff): int
E_USER_ERROR,
E_USER_WARNING,
E_USER_NOTICE,
E_STRICT,
self::E_STRICT,
E_RECOVERABLE_ERROR,
E_DEPRECATED,
E_USER_DEPRECATED,
Expand Down
2 changes: 1 addition & 1 deletion src/Settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ public static function settings(): array
E_USER_ERROR => 'User-generated error messages (E_USER_ERROR) and above',
E_USER_WARNING => 'User-generated warning messages (E_USER_WARNING) and above',
E_USER_NOTICE => 'User-generated notice messages (E_USER_NOTICE) and above',
E_STRICT => 'Suggest code changes to ensure forward compatibility (E_STRICT) and above',
Plugin::E_STRICT => 'Suggest code changes to ensure forward compatibility (E_STRICT) and above',
E_DEPRECATED => 'Warnings about code that won\'t work in future versions (E_DEPRECATED) and above',
E_ALL => 'Absolutely everything (E_ALL)',
],
Expand Down