Removed the timeout from wallet recover as large nodes were having issues - #1154
Open
0xfornax wants to merge 3 commits into
Open
Removed the timeout from wallet recover as large nodes were having issues#11540xfornax wants to merge 3 commits into
0xfornax wants to merge 3 commits into
Conversation
0xfornax
changed the title
0xfornax
force-pushed
the
remove-timeout-recover-wallet
branch
from
August 1, 2026 14:04
b429f60 to
9393e21
Compare
0xfornax
force-pushed
the
remove-timeout-recover-wallet
branch
from
August 1, 2026 18:08
9393e21 to
ec06c62
Compare
Merging this branch changes the coverage (1 decrease, 2 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
0xfornax
marked this pull request as ready for review
August 1, 2026 18:15
Member
Author
|
Closes #1149 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wallet recover and rebuild on large nodes can exceed the CLIs default HTTP timeout. This PR drops that timeout. The daemon now allows only one recover, test-recovery, or rebuild at a time, exposes progress via GET /api/wallet/recovery-status, and rejects concurrent attempts with the in-flight operation and key progress. The CLI now confirms the effects of those commands, polls and prints recovery progress, and reports if work is already running on the daemon.