fix open dir for wxpython 4.3 - #3064
Open
JFoederer wants to merge 3 commits into
Open
Conversation
Collaborator
Author
|
Pipelines fail, because there are a lot of version-specific wxPython dependencies in the jobs. |
HelioGuilherme66
requested changes
Aug 8, 2026
HelioGuilherme66
left a comment
HelioGuilherme66
left a comment
Member
There was a problem hiding this comment.
Please condition to wxPython versions, only change mainframe.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolution for issue #3063
Even though the documentation states that the argument is correct: https://docs.wxpython.org/wx.functions.html#wx.DirSelector
It also states that the arguments are the same meaning as those of DirDialog.init. Only there they changed:
default_path->defaultPath.