Repository navigation
build: publish the Composer package as roadrunner/roadrunner - #2431
Merged
rustatian merged 1 commit intoOct 19, 2026
Merged
Conversation
The spiral/roadrunner name carries the calendar versions, so Composer and Packagist rank 2025.x above 3.x, and advisory GHSA-g9pc-8g42-g6vq (< 2025.1.0) matches 3.x. The new name starts at the 3.x line. It does not replace spiral/roadrunner yet: Composer applies advisories and conflicts of a replaced name to the replacing package, so the replace can come once the advisory range is fixed. Assisted-By: Claude Opus 5.5 Signed-off-by: roxblnfk <roxblnfk@ya.ru>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2431 +/- ##
=======================================
Coverage 34.42% 34.42%
=======================================
Files 18 18
Lines 761 761
=======================================
Hits 262 262
Misses 499 499 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for This PR
The Composer metapackage
spiral/roadrunnercarries the calendar versions 2023.x–2025.x, so Composer and Packagist rank 2025.x above 3.x: Packagist shows 2025.1.x as the latest version, andcomposer require spiral/roadrunnerwithout a constraint installs 2025.1.x. Advisory GHSA-g9pc-8g42-g6vq (CVE-2025-22871,< 2025.1.0) also matches 3.x, which blocks installing RoadRunner 3 with Composer 2.9+ androave/security-advisories(#2422).Description of Changes
roadrunner/roadrunner, starting from the 3.x line; the README badges point to it.replacespiral/roadrunneryet — see below.Why no
replaceofspiral/roadrunneryetSecurityAdvisoryPoolFilter::getMatchingAdvisories()iteratesgetNames(false), which includes replaced names). With"replace": {"spiral/roadrunner": "self.version"},roadrunner/roadrunner3.x would still match GHSA-g9pc-8g42-g6vq and be blocked.conflictrules work the same way:roave/security-advisories(spiral/roadrunner <2025.1) andlaravel/octane(spiral/roadrunner <2023.1.0) would conflict with the replacing package too.replacenothing breaks: old packages that still requirespiral/roadrunnerinstall it next toroadrunner/roadrunner. Thereplacecan be added once [GHSA-g9pc-8g42-g6vq] RoadRunner is at risk of HTTP Request/Response Smuggling through vulnerable dependency github/advisory-database#10283 fixes the advisory range.Review notes
composer.jsonstill saysspiral/roadrunner. Afterroadrunner/roadrunneris submitted, its versions below 3.0.0 have to be deleted on Packagist, otherwise 2025.1.x becomes its latest version again.spiral/roadrunnerkeeps receiving new tags; mark it abandoned only after theroadrunner/*PHP packages requireroadrunner/roadrunner ^3.0instead ofspiral/roadrunner ^3.0.License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
PR Checklist
git commit -s).CHANGELOG.md. (Release Please generates it.)