Skip to content

chore(release): update version to 2.3.23 - #5816

Draft
NathanFlurry wants to merge 4 commits into
mainfrom
release/2.3.23
Draft

NathanFlurry wants to merge 4 commits into
mainfrom
release/2.3.23

Conversation

@NathanFlurry

Copy link
Copy Markdown
Member
  • Update public release versions to 2.3.23.
  • Include the merged independent-package dependency fix and preserve the release publishing fixes from 2.3.22.

@railway-app

railway-app Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

🚅 Deployed to the rivet-pr-5816 environment in rivet-frontend

Service Status Web Updated
frontend-cloud 😴 Sleeping (View Logs) Web Oct 2, 2026 at 1:39 am UTC
frontend-inspector 😴 Sleeping (View Logs) Web Oct 2, 2026 at 1:38 am UTC
kitchen-sink 😴 Sleeping (View Logs) Web Oct 2, 2026 at 1:34 am UTC
ladle ✅ Success (View Logs) Web Oct 2, 2026 at 1:28 am UTC
mcp-hub ✅ Success (View Logs) Web Oct 2, 2026 at 1:26 am UTC
website ❌ Build Failed (View Logs) Web Oct 2, 2026 at 1:26 am UTC

@claude

claude Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Review: chore(release): update version to 2.3.23

Mostly mechanical version bump, plus publish-flow fixes. I found one likely blocker and a few smaller points.

Likely blocker: Cargo.lock is stale
Cargo.toml goes to 2.3.23 (workspace version and the =2.3.23 pins), but Cargo.lock still says 2.3.22 for the workspace crates (for example rivet-engine). Commit 4/4 touched Cargo.toml and the package.json files but not the lock. cargo build --locked or --frozen will fail on the mismatch, and other builds will rewrite the lock in CI. Please regenerate and commit Cargo.lock.

scripts/publish/src/lib/npm.ts: registry pre-check in publishOne

  • The new fetch has no timeout or retry. A transient 5xx or 429 now marks the package failed with attempts: 0 and skips the existing retry and backoff loop. Consider retrying transient statuses, or falling through to npm publish. Add an AbortSignal.timeout too.
  • Please confirm already-exists here still reaches the same dist-tag repair path as the old stderr-parsed case.

check-npm-oidc (bin.ts)

  • The hardcoded skip for @rivet-dev/pi and @rivet-dev/sandbox-adapter is brittle. Once those packages are bootstrapped it becomes dead code that can hide real failures. Consider a named constant with a TODO, or an allowlist.
  • Please verify the OIDC audience and exchange endpoint against npm's trusted-publishing flow. A breakage there blocks every release at the context step. Gating on trigger == 'release' limits the blast radius.
  • pkg.name.replace("/", "%2f") is fine for scoped names, but encodeURIComponent is clearer and matches npm.ts.

publish.yaml

  • Add a comment on why node-version is pinned to 24.20.0 (trusted publishing needs a recent npm), so it isn't unpinned by accident.
  • id-token: write on the context job is needed and looks fine.

version.ts and tests
The ^${version} handling for independent packages is sensible. I didn't see tests for it or for the publishAll rc filter. Small unit tests would protect the release path.

Minor

  • docker/build/windows-x64.Dockerfile: installing nasm is fine. It may belong in the builder-base-windows-mingw base image later.

No security concerns. The main thing to fix before merging is the Cargo.lock mismatch.

This branch had an error being deployed

1 failed deployment
rivet-frontend / rivet-pr-5816 — f4785c56 Deployed Oct 2, 2026 by railway-app[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant