Skip to content

feat(rivetkit): add per-call poolName option to getOrCreate and create - #5496

Merged
abcxff merged 5 commits into
mainfrom
stack/feat-rivetkit-add-per-call-poolname-option-to-getorcreate-and-create-ylosnxmq
Jul 31, 2026
Merged

feat(rivetkit): add per-call poolName option to getOrCreate and create#5496
abcxff merged 5 commits into
mainfrom
stack/feat-rivetkit-add-per-call-poolname-option-to-getorcreate-and-create-ylosnxmq

Conversation

@abcxff

@abcxff abcxff commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@abcxff

abcxff commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

@railway-app
railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5496 July 28, 2026 14:49 Destroyed
@claude

claude Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review

Clean, well-scoped feature: adds a per-call poolName override to getOrCreate/create on both the Rust client and TypeScript engine client, falling back to the client's configured pool name. Plumbing is symmetric across both languages (options struct -> query/request schema -> wire request -> gateway URL query param), and the test coverage mirrors that symmetry nicely (override + fallback cases for create, getOrCreate, and gateway_url/buildGatewayUrl on both sides).

Re-verified against the latest commit (9b3e592); the diff is unchanged from the prior review.

Findings

Nit - pre-existing dead option, adjacent to this change (Rust Client::create): rivetkit-rust/packages/client/src/client.rs create() still does let _region = opts.region; and never forwards it. RemoteManager::create_actor (and the wire-level ActorsCreateRequest) has no region field at all, so CreateOptions.region has silently had zero effect even before this PR. Not introduced here, but this PR touches the exact same CreateOptions/create() path to wire up pool_name, so it is a good opportunity to either fix or remove region from CreateOptions so the two per-call overrides do not have inconsistent behavior (pool_name works, region silently does not).

Nit - no cross-SDK parity for Swift: rivetkit-swift ActorQuery/RemoteManager only supports pool name via client config, no per-call override. Not required by CLAUDE.md (parity rules there are scoped to the runner protocol, not client SDKs), but worth a follow-up if per-call pool selection is meant to be a first-class cross-SDK feature.

Nit - empty-string override not guarded: both pool_name.unwrap_or_else(...) (Rust) and the TS poolName ?? this.#config.poolName fallback treat an explicit empty string as a valid override rather than falling back. Probably fine since this mirrors existing region/createInRegion handling, just flagging in case an empty string should be treated as unset.

Nothing blocking. Good test coverage on both the Rust (bare.rs) and TypeScript (remote-engine-client-pool-name.test.ts) sides, including the gateway-URL query-param paths in addition to the JSON body paths.

@abcxff
abcxff force-pushed the stack/feat-rivetkit-add-per-call-poolname-option-to-getorcreate-and-create-ylosnxmq branch from d61c36b to 77885a4 Compare July 28, 2026 14:57
@railway-app
railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5496 July 28, 2026 14:57 Destroyed
@railway-app

railway-app Bot commented Jul 28, 2026

Copy link
Copy Markdown

🚅 Deployed to the rivet-pr-5496 environment in rivet-frontend

Service Status Web Updated (UTC)
kitchen-sink 😴 Sleeping (View Logs) Web Jul 31, 2026 at 5:30 pm
frontend-inspector 😴 Sleeping (View Logs) Web Jul 31, 2026 at 5:29 pm
frontend-cloud 😴 Sleeping (View Logs) Web Jul 31, 2026 at 5:27 pm
website 😴 Sleeping (View Logs) Web Jul 31, 2026 at 4:41 pm
mcp-hub ✅ Success (View Logs) Web Jul 31, 2026 at 4:29 pm
ladle ✅ Success (View Logs) Web Jul 28, 2026 at 2:51 pm

@abcxff
abcxff requested a review from NathanFlurry July 30, 2026 03:27
@abcxff
abcxff force-pushed the stack/feat-rivetkit-add-per-call-poolname-option-to-getorcreate-and-create-ylosnxmq branch from 77885a4 to 975bf39 Compare July 30, 2026 19:59
@abcxff
abcxff changed the base branch from main to stack/feat-frontend-pool-switcher-and-pool-scoped-titles-for-logs-and-compute-xwmxvxvp July 30, 2026 19:59
@railway-app
railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5496 July 30, 2026 19:59 Destroyed
@abcxff
abcxff force-pushed the stack/feat-rivetkit-add-per-call-poolname-option-to-getorcreate-and-create-ylosnxmq branch from 975bf39 to 9c4267c Compare July 31, 2026 05:35
@abcxff
abcxff force-pushed the stack/feat-frontend-pool-switcher-and-pool-scoped-titles-for-logs-and-compute-xwmxvxvp branch from 289ca6e to 919f407 Compare July 31, 2026 05:35
@railway-app
railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5496 July 31, 2026 05:35 Destroyed
@abcxff
abcxff force-pushed the stack/feat-frontend-pool-switcher-and-pool-scoped-titles-for-logs-and-compute-xwmxvxvp branch from 919f407 to d81fef1 Compare July 31, 2026 16:29
@abcxff
abcxff changed the base branch from stack/feat-frontend-pool-switcher-and-pool-scoped-titles-for-logs-and-compute-xwmxvxvp to stack/fix-frontend-source-actor-deployment-logs-pool-from-runner_name_selector-lxourmkm July 31, 2026 16:29
@abcxff
abcxff force-pushed the stack/feat-rivetkit-add-per-call-poolname-option-to-getorcreate-and-create-ylosnxmq branch from 9c4267c to a8f98b7 Compare July 31, 2026 16:29
@railway-app
railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5496 July 31, 2026 16:29 Destroyed
@abcxff
abcxff force-pushed the stack/fix-frontend-source-actor-deployment-logs-pool-from-runner_name_selector-lxourmkm branch from d02f373 to fcd4c9e Compare July 31, 2026 16:56
@abcxff
abcxff force-pushed the stack/feat-rivetkit-add-per-call-poolname-option-to-getorcreate-and-create-ylosnxmq branch from a8f98b7 to 4aa0cc7 Compare July 31, 2026 16:56
@railway-app
railway-app Bot temporarily deployed to rivet-frontend / rivet-pr-5496 July 31, 2026 16:56 Destroyed
@railway-app
railway-app Bot temporarily deployed to rivet-frontend / production July 31, 2026 17:31 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants