feat(rivetkit): add per-call poolName option to getOrCreate and create - #5496
Conversation
|
Stack for rivet-dev/rivet
Get stack: change ylosnxmq |
ReviewClean, well-scoped feature: adds a per-call poolName override to getOrCreate/create on both the Rust client and TypeScript engine client, falling back to the client's configured pool name. Plumbing is symmetric across both languages (options struct -> query/request schema -> wire request -> gateway URL query param), and the test coverage mirrors that symmetry nicely (override + fallback cases for create, getOrCreate, and gateway_url/buildGatewayUrl on both sides). Re-verified against the latest commit (9b3e592); the diff is unchanged from the prior review. Findings Nit - pre-existing dead option, adjacent to this change (Rust Client::create): rivetkit-rust/packages/client/src/client.rs create() still does Nit - no cross-SDK parity for Swift: rivetkit-swift ActorQuery/RemoteManager only supports pool name via client config, no per-call override. Not required by CLAUDE.md (parity rules there are scoped to the runner protocol, not client SDKs), but worth a follow-up if per-call pool selection is meant to be a first-class cross-SDK feature. Nit - empty-string override not guarded: both Nothing blocking. Good test coverage on both the Rust (bare.rs) and TypeScript (remote-engine-client-pool-name.test.ts) sides, including the gateway-URL query-param paths in addition to the JSON body paths. |
d61c36b to
77885a4
Compare
|
🚅 Deployed to the rivet-pr-5496 environment in rivet-frontend
|
77885a4 to
975bf39
Compare
975bf39 to
9c4267c
Compare
289ca6e to
919f407
Compare
919f407 to
d81fef1
Compare
9c4267c to
a8f98b7
Compare
d02f373 to
fcd4c9e
Compare
a8f98b7 to
4aa0cc7
Compare
No description provided.