Repository navigation
fix(core): reject execution waits when a VM is disposed - #2030
Draft
DevEverything01 wants to merge 2 commits into
Draft
DevEverything01 wants to merge 2 commits into
DevEverything01 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ERR_AGENTOS_VM_DISPOSEDwhen disposal starts. Keep native teardown and its errors observable, preserve sibling VMs, and avoid reconciling an already-exited process through a disposed public wait.Related: shared sidecars #1531 and guest-fetch disposal #2014. This changes SDK wait settlement; shared-sidecar callback routing is prepared separately.
Also release the TypeScript shared-sidecar lease hold in a
finallyblock when native VM disposal rejects. Preserve the disposal error and keep sibling VMs usable. A real subprocess regression injects a rejection after successful native cleanup, runs a sibling VM timer, and verifies that the host exits naturally after the final lease is disposed. Include both success and failure exit cases in the Core PR test lane. This closes SDK event-loop reference cleanup; it does not prove native cleanup after a real teardown failure. Validation ran on macOS arm64, not upstream Linux CI.🤖 Generated with Claude Code