feat(profile): replace stubbed useProfileUpdate with real API call (#936) - #1125
Merged
Merged
Conversation
- Create PUT /api/user/profile endpoint with Zod validation - Replace setTimeout stub in useProfileUpdate with apiClient.put call - Propagate server-side validation errors to form fields via setError - Hook returns typed ProfileUpdateResponse with field-level errors Closes rinafcode#936
|
@omosvico Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #936
Problem:
useProfileUpdateusedawait new Promise(r => setTimeout(r, 1000))and returned a synthesized success response — profile edits appeared to save but persisted nothing.Changes:
New API route
src/app/api/user/profile/route.ts— PUT handler with Zod validation for all profile fields, returns field-level errors on validation failure.Updated hook
src/app/hooks/useProfileUpdate.ts— replaced thesetTimeoutstub withapiClient.put("/api/user/profile", data). The typedProfileUpdateResponseinterface includeserrors?: { field: string; message: string }[]for propagation.Updated form
src/app/components/profile/ProfileEditForm.tsx— catchesApiErrorwith field errors and callssetErrorfrom react-hook-form to highlight the offending fields with server-side validation messages.