test(useQuiz): add navigation bounds and review-mode guard tests (#948) - #1124
Merged
RUKAYAT-CODER merged 1 commit intoJul 30, 2026
Merged
Conversation
Add tests for: - goPrevious clamping at index 0 when already at first question - goNext clamping at questions.length - 1 when already at last question - canGoNext/canGoPrevious boundary state reflection - enterReviewMode no-op before completion - exitReviewMode no-op before completion - enterReviewMode sets review mode after completion - exitReviewMode clears review mode after completion Closes rinafcode#948
|
@vstudio79 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #948
What – Add test coverage for the following paths in
useQuiz.tsx:Navigation bounds (
goNext/goPrevious, lines 231-237)goPreviousat the first question clamps to index 0goNextat the last question clamps toquestions.length - 1canGoNext/canGoPreviouscorrectly reflect boundary stateReview-mode guards (
enterReviewMode/exitReviewMode, lines 362-370)isCompletedis false)enterReviewModesetsisReviewModeaftercomplete()is calledexitReviewModeclearsisReviewModeafter completionWhy – Off-by-one navigation errors would let users skip past or re-answer questions. The review-mode guards prevent entering or leaving review before completion; untested they could allow invalid state transitions.
All 12 tests pass.