Fix: Add authentication and admin authorization guards to RolesController - #1149
Merged
RUKAYAT-CODER merged 3 commits intoJul 30, 2026
Merged
Conversation
|
@Ultra-Tech-code Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Kindly resolve conflict |
Contributor
|
Thank you for contributing to the project. |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #966
Overview
This PR addresses a critical authorization gap in the RBAC implementation where the
RolesControllerCRUD endpoints were missing authentication and authorization guards. Previously, these endpoints were reachable by any unauthenticated caller, allowing for potential privilege escalation to administrator.Changes Made
@UseGuards(JwtAuthGuard, RolesGuard)and@Roles('admin')at theRolesControllerclass level.@ApiBearerAuth()so the Swagger contract reflects the authorization requirement.CreateRoleDtoandUpdateRoleDto(using@IsString,@IsOptional, and@IsUUID({ each: true })), enabling the globalValidationPipewhitelist.id/sub,email,ipAddress, anduserAgent) from the request and pass it to theRolesServiceto properly record role and permission changes with the acting principal.test/security/roles-rbac.e2e-spec.ts) asserting thatPOST /rolesreturns a401without a token and a403with a non-admin token.