Skip to content

chore: upgrade thrift and @tiptap/* to resolve Dependabot alerts - #9874

Open
himadrisingh wants to merge 1 commit into
mainfrom
hsingh/dependabot-thrift-tiptap
Open

himadrisingh wants to merge 1 commit into
mainfrom
hsingh/dependabot-thrift-tiptap

Conversation

@himadrisingh

@himadrisingh himadrisingh commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Resolves three open Dependabot security alerts:

  • github.com/apache/thrift 0.22.0 → 0.24.0 — GHSA-8wv5-x4w7-5gww (high): infinite loop in the Go bindings. Transitive via databricks-sql-goruntime/drivers/databricks; a clean one-line bump with no cascade.
  • @tiptap/* (8 packages) 3.20.1 → 3.31.3 — GHSA-j95f-988m-3j2f (high): quadratic ReDoS in Markdown attribute parsing, and GHSA-cp6q-959q-f8rh (medium): mergeAttributes() turns an own __proto__ key into inherited executable DOM attributes. All @tiptap/* packages move together since the library requires matching versions across the family.

Verified: go build ./... passes, npm run build passes for both web-local and web-admin, and svelte-check reports no errors at the three @tiptap call sites under web-common/src/features/chat/core/.

The grpc alert is handled separately in #9873, since that one cascades a large set of transitive upgrades. The two PRs overlap on go.mod, so whichever merges second needs a rebase.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

Developed in collaboration with Claude Code

🤖 Generated with Claude Code

- `github.com/apache/thrift` 0.22.0 -> 0.24.0 (GHSA-8wv5-x4w7-5gww: infinite loop in Go bindings)
- `@tiptap/*` 3.20.1 -> 3.31.3 (GHSA-j95f-988m-3j2f: quadratic ReDoS in Markdown attribute parsing; GHSA-cp6q-959q-f8rh: `mergeAttributes()` prototype pollution)

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

@nishantmonu51 nishantmonu51 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , LGTM post CI failures are fixed.

@nishantmonu51 nishantmonu51 added dependencies Pull requests that update a dependency file Size:M Medium change: 100-499 lines labels Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file Size:M Medium change: 100-499 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants