Skip to content

chore: migrate time dropdown config to i18n - #9754

Merged
AdityaHegde merged 2 commits into
mainfrom
chore/migrate-time-config-to-i18n
Jul 28, 2026
Merged

chore: migrate time dropdown config to i18n#9754
AdityaHegde merged 2 commits into
mainfrom
chore/migrate-time-config-to-i18n

Conversation

@AdityaHegde

Copy link
Copy Markdown
Collaborator

We migrated a few text to paraglide's i18n messages. A lot of text were missing from this migration.

  1. Updates the script for auditing the code for hardcoded messages. Will only warn for now.
  2. Added a migration plan doc for splitting the effort into PRs.
  3. Migrated the 1st part of the plan, time range dropdown and related code.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@nishantmonu51

Copy link
Copy Markdown
Collaborator

@codex: review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4feed37cc2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/i18n-guard.js

@nishantmonu51 nishantmonu51 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , LGTM

@AdityaHegde
AdityaHegde merged commit 66cafd9 into main Jul 28, 2026
11 checks passed
@AdityaHegde
AdityaHegde deleted the chore/migrate-time-config-to-i18n branch July 28, 2026 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants