Repository navigation
feat(connection): add connection pool context awareness support - #19
Merged
Merged
Conversation
Add comprehensive tests for connection pool concurrency: - Test concurrent connections are distinct - Test concurrent operations don't cause deadlocks - Test query results don't get mixed between connections - Test concurrent transactions are properly isolated - Add stress tests for high concurrent load Both sync (BackendPool) and async (AsyncBackendPool) tests are included.
Implement IBasicConnectionProvider and IQueryConnectionProvider for PostgreSQL backend to support testsuite connection pool tests. - Add BasicConnectionProvider for feature.basic.connection tests - Add QueryConnectionProvider for feature.query.connection tests - Register both providers in registry.py
Import tests from testsuite for connection pool context awareness: - feature/basic/connection/ - ActiveRecord context and CRUD tests - feature/query/connection/ - ActiveQuery, CTEQuery, SetOperationQuery tests These tests use the provider pattern to run backend-agnostic tests defined in testsuite.
Change rhosocial-activerecord to git+https@release/v1.0.0.dev22 Change rhosocial-activerecord-testsuite to git+https@release/v1.0.0.dev9
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/v1.0.0.dev9 #19 +/- ##
====================================================
Coverage 71.70% 71.70%
====================================================
Files 112 112
Lines 6191 6191
Branches 991 991
====================================================
Hits 4439 4439
Misses 1440 1440
Partials 312 312
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vistart
marked this pull request as ready for review
April 7, 2026 09:15
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
vistart
added a commit
that referenced
this pull request
Apr 8, 2026
* test(connection): add concurrent connection pool tests Add comprehensive tests for connection pool concurrency: - Test concurrent connections are distinct - Test concurrent operations don't cause deadlocks - Test query results don't get mixed between connections - Test concurrent transactions are properly isolated - Add stress tests for high concurrent load Both sync (BackendPool) and async (AsyncBackendPool) tests are included. * feat: add connection pool context awareness providers Implement IBasicConnectionProvider and IQueryConnectionProvider for PostgreSQL backend to support testsuite connection pool tests. - Add BasicConnectionProvider for feature.basic.connection tests - Add QueryConnectionProvider for feature.query.connection tests - Register both providers in registry.py * feat: add testsuite connection pool context awareness tests Import tests from testsuite for connection pool context awareness: - feature/basic/connection/ - ActiveRecord context and CRUD tests - feature/query/connection/ - ActiveQuery, CTEQuery, SetOperationQuery tests These tests use the provider pattern to run backend-agnostic tests defined in testsuite. * ci: install dependencies from git instead of PyPI Change rhosocial-activerecord to git+https@release/v1.0.0.dev22 Change rhosocial-activerecord-testsuite to git+https@release/v1.0.0.dev9 * chore: add changelog fragment for PR #19 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Add connection pool context awareness support for PostgreSQL backend, enabling proper connection management across different execution contexts (sync/async, transaction boundaries).
This feature introduces:
Type of change
feat: A new featuretest: Adding missing tests or correcting existing testsci: Changes to our CI configuration files and scriptsBreaking Change
Applicable
rhosocial-activerecordVersion Range:Related Repositories/Packages
python-activerecord-testsuite: Requires coordinated changes for connection pool context awareness providersTesting
Test Plan:
pytest tests/rhosocial/activerecord_test/feature/connection/- connection pool concurrent testspytest tests/rhosocial/activerecord_test/feature/basic/connection/- basic connection context testspytest tests/rhosocial/activerecord_test/feature/query/connection/- query connection context testsCommits in this PR
31382ectest(connection): add concurrent connection pool testsda68e8cfeat: add connection pool context awareness providers99b3155feat: add testsuite connection pool context awareness tests3aa88b5ci: install dependencies from git instead of PyPIChecklist
changelog.d/<issue_number>.<type>.md).Additional Notes
This PR is part of the connection pool context awareness feature development cycle for v1.0.0.dev9.